Disassembly displays old source (caching issue?) and search is broken #577
Comments
|
how do you trigger this? can you give more detailed information please? |
|
just retested with today's appimage
result: you mostly see the source of source1, instead of source2, but the title is set to and the syntax language is used according to source2 and the number of lines is limited to the lines of the function in source2 |
|
Just to make sure, you are using the correct version of your executable? Disassembler works with addresses not and dwarf information. In theory a compiler can generate two different binaries for the same source code. Depending if he reorders the binary or not (used in obfuscated code to make leaked debug infos unusable). I sometimes encounter a similar problem after a compiler change / update. |
|
Sometimes the binaries are out of date, often just recompiled. If there are differences then the counters are off by some lines (or plain wrong when the code around it changed). But this is about totally showing the wrong source, and this is "new" and happens since the last big Disassembly overhaul. |
|
also: for the situation you describe @lievenhey we should ideally catch it and noisily show a warning to the user. we can detect it by comparing buildids. |
|
I guess you cannot reproduce that with the appimage? Do we need something like an explicit update call to also change the content of the lines? |
The search functions only works on a limited range, but the model contained the complete source code. This patch runs the search function on only a subset of that code. fixes: #577
The search functions only works on a limited range, but the model contained the complete source code. This patch runs the search function on only a subset of that code. fixes: #577
The search functions only works on a limited range, but the model contained the complete source code. This patch runs the search function on only a subset of that code. fixes: #577
|
Ah, found it (actually @milianw but in another context). In |
The vectors containing the source code are not reset correctly. This results one some old code being shown. This patch resets them correctly. fixes: #577
Don't always append data, resize-to-fit and then transform. Sadly, QStringList has no resize, so we need to copy+for_each there instead. Fixes: #577
Don't always append data, resize-to-fit and then transform. Sadly, QStringList has no resize, so we need to copy+for_each there instead. Fixes: #577
|
@GitMensch wrote:
|
The search functions only works on a limited range, but the model contained the complete source code. This patch runs the search function on only a subset of that code. fixes: #577
The search functions only works on a limited range, but the model contained the complete source code. This patch runs the search function on only a subset of that code. fixes: #577
The search functions only works on a limited range, but the model contained the complete source code. This patch runs the search function on only a subset of that code. fixes: KDAB#577
The search functions only works on a limited range, but the model contained the complete source code. This patch runs the search function on only a subset of that code. fixes: KDAB#577
Describe the bug
Use of Disassembly shows partially (and not always) the source of a previous disassembly.
Furthermore the search function seems to be totally broken.
@lievenhey I guess you can reproduce and want to have a look at this. Search definitely worked in older appimages and "caching atifacts" also seem to be a new thing.
The text was updated successfully, but these errors were encountered: