Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make syntax highlighting customizeable #448

Merged
merged 1 commit into from
Dec 12, 2022
Merged

make syntax highlighting customizeable #448

merged 1 commit into from
Dec 12, 2022

Conversation

lievenhey
Copy link
Contributor

fixes #434

@lievenhey lievenhey force-pushed the configureable-highlighting branch 2 times, most recently from 68804b9 to 3125c2c Compare December 5, 2022 17:36
@lievenhey lievenhey requested a review from milianw December 5, 2022 17:36
@lievenhey lievenhey force-pushed the configureable-highlighting branch 2 times, most recently from 135d1bd to 5086341 Compare December 5, 2022 17:53
milianw
milianw requested changes Dec 5, 2022
View reviewed changes
src/models/disassemblymodel.h Outdated Show resolved Hide resolved
src/models/disassemblymodel.cpp Outdated Show resolved Hide resolved
src/models/sourcecodemodel.cpp Outdated Show resolved Hide resolved
src/models/sourcecodemodel.h Outdated Show resolved Hide resolved
src/resultsdisassemblypage.cpp Outdated Show resolved Hide resolved
src/resultsdisassemblypage.cpp Outdated Show resolved Hide resolved
src/resultsdisassemblypage.cpp Outdated Show resolved Hide resolved
@lievenhey lievenhey requested a review from milianw December 6, 2022 14:18
@lievenhey lievenhey force-pushed the configureable-highlighting branch from 5086341 to 9a2e5bd Compare December 6, 2022 14:24
milianw
milianw requested changes Dec 6, 2022
View reviewed changes
src/resultsdisassemblypage.cpp Outdated Show resolved Hide resolved
src/resultsdisassemblypage.cpp Outdated Show resolved Hide resolved
src/models/highlighter.cpp Show resolved Hide resolved
@lievenhey lievenhey force-pushed the configureable-highlighting branch from 9a2e5bd to b23f460 Compare December 7, 2022 14:37
@lievenhey lievenhey requested a review from milianw December 7, 2022 14:38
@lievenhey lievenhey force-pushed the configureable-highlighting branch 2 times, most recently from 34c0c8c to 62c52b9 Compare December 7, 2022 14:43
@GitMensch
Copy link
Contributor

Thanks!

milianw
milianw requested changes Dec 8, 2022
View reviewed changes
src/models/disassemblymodel.h Outdated Show resolved Hide resolved
src/models/highlighter.hpp Show resolved Hide resolved
src/models/sourcecodemodel.h Outdated Show resolved Hide resolved
src/resultsdisassemblypage.cpp Outdated Show resolved Hide resolved
src/resultsdisassemblypage.cpp Outdated Show resolved Hide resolved
src/resultsdisassemblypage.cpp Show resolved Hide resolved
src/models/highlighter.cpp Outdated Show resolved Hide resolved
@lievenhey lievenhey force-pushed the configureable-highlighting branch 3 times, most recently from d1ad1ba to 25659df Compare December 9, 2022 10:37
@milianw milianw merged commit ff86112 into master Dec 12, 2022
@milianw milianw deleted the configureable-highlighting branch December 12, 2022 07:42
@GitMensch
Copy link
Contributor

Thank you for all those useful changes to the new view! The only feature-wise thing open is #425 (I may be able to try adding that using QTextDocument.find [the hardest part for me would be the popup? to add, allowing the user to entering his search and the FindFlags]) and the likely more complicated #418 (something I don't feel comfortable tinkering with).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milianw milianw milianw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FR Source Code window: configurable source highlighting
3 participants
@lievenhey @GitMensch @milianw