Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set source path #486

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Set source path #486

merged 1 commit into from
Jul 4, 2023

Conversation

lievenhey
Copy link
Contributor

this patch add allows the user to add a custom source path which will
overwrite the source path provided in the binary
this makes the disassembler, ... work if the source code directory was
moved after creating the binary

closes: #418

src/models/disassemblyoutput.cpp Outdated Show resolved Hide resolved
src/models/disassemblyoutput.cpp Outdated Show resolved Hide resolved
@lievenhey lievenhey force-pushed the set-source-path branch 2 times, most recently from 7a9187e to 2ab5d53 Compare June 29, 2023 12:58
@lievenhey lievenhey requested a review from milianw June 29, 2023 13:05
@lievenhey lievenhey dismissed milianw’s stale review June 29, 2023 13:05

changes applied

tests/modeltests/tst_disassemblyoutput.cpp Outdated Show resolved Hide resolved
tests/modeltests/tst_disassemblyoutput.cpp Outdated Show resolved Hide resolved
tests/modeltests/tst_disassemblyoutput.cpp Show resolved Hide resolved
this patch add allows the user to add a custom source path which will
overwrite the source path provided in the binary
this makes the disassembler, ... work if the source code directory was
moved after creating the binary

closes: #418
Copy link
Member

@milianw milianw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, feel free to push once the CI has tested it

@lievenhey lievenhey merged commit f300bbf into master Jul 4, 2023
@lievenhey lievenhey deleted the set-source-path branch July 4, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: add option to set source paths
2 participants