Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor typo correction: unknown #540

Merged
merged 2 commits into from
Nov 1, 2023
Merged

minor typo correction: unknown #540

merged 2 commits into from
Nov 1, 2023

Conversation

GitMensch
Copy link
Contributor

additional: reordered checks in brushSystem

milianw
milianw requested changes Oct 29, 2023
View reviewed changes
Copy link
Member

@milianw milianw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please split this up into two patches, otherwise this lgtm

milianw
milianw reviewed Oct 29, 2023
View reviewed changes
src/main.cpp Outdated Show resolved Hide resolved
@GitMensch
Copy link
Contributor Author

GitMensch commented Oct 29, 2023 via email

@milianw
Copy link
Member

milianw commented Oct 29, 2023

Is one PR with two commits fine or so you want separate PRs?

one merge request, many commits

@GitMensch
Copy link
Contributor Author

split as requested

@GitMensch GitMensch requested a review from milianw October 30, 2023 19:57
@milianw milianw merged commit 89c3808 into KDAB:master Nov 1, 2023
12 checks passed
@GitMensch GitMensch deleted the unknown branch November 2, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milianw milianw milianw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GitMensch @milianw