Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STDIN が空の場合も API を叩いている #8

Closed
KEINOS opened this issue Jul 7, 2021 · 1 comment
Closed

STDIN が空の場合も API を叩いている #8

KEINOS opened this issue Jul 7, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@KEINOS
Copy link
Owner

KEINOS commented Jul 7, 2021

以下のログのように、空の場合でもキャッシュと API を呼び出しています。もったいない。

strings.TrimSpace() しても空の場合はストレートに空の文字列を返すべきです。

$ echo -n "" | qiitrans ja en ja --debug
badger 2021/07/07 02:37:39 INFO: All 2 tables opened in 0s
badger 2021/07/07 02:37:39 INFO: Discard stats nextEmptySlot: 0
badger 2021/07/07 02:37:39 INFO: Set nextTxnTs to 2
badger 2021/07/07 02:37:39 INFO: Deleting empty file: /tmp/QiiTrans/000003.vlog
badger 2021/07/07 02:37:39 INFO: Lifetime L0 stalled for: 0s
badger 2021/07/07 02:37:39 INFO: 
Level 0 [ ]: NumTables: 02. Size: 584 B of 0 B. Score: 0.00->0.00 StaleData: 0 B Target FileSize: 64 MiB
Level 1 [ ]: NumTables: 00. Size: 0 B of 10 MiB. Score: 0.00->0.00 StaleData: 0 B Target FileSize: 2.0 MiB
Level 2 [ ]: NumTables: 00. Size: 0 B of 10 MiB. Score: 0.00->0.00 StaleData: 0 B Target FileSize: 2.0 MiB
Level 3 [ ]: NumTables: 00. Size: 0 B of 10 MiB. Score: 0.00->0.00 StaleData: 0 B Target FileSize: 2.0 MiB
Level 4 [ ]: NumTables: 00. Size: 0 B of 10 MiB. Score: 0.00->0.00 StaleData: 0 B Target FileSize: 2.0 MiB
Level 5 [ ]: NumTables: 00. Size: 0 B of 10 MiB. Score: 0.00->0.00 StaleData: 0 B Target FileSize: 2.0 MiB
Level 6 [B]: NumTables: 00. Size: 0 B of 10 MiB. Score: 0.00->0.00 StaleData: 0 B Target FileSize: 2.0 MiB
Level Done
[LOG]: JA -> EN: 新規取得: 
badger 2021/07/07 02:37:41 INFO: All 2 tables opened in 1ms
badger 2021/07/07 02:37:41 INFO: Discard stats nextEmptySlot: 0
badger 2021/07/07 02:37:41 INFO: Set nextTxnTs to 2
badger 2021/07/07 02:37:41 INFO: Deleting empty file: /tmp/QiiTrans/000004.vlog
badger 2021/07/07 02:37:41 INFO: Lifetime L0 stalled for: 0s
badger 2021/07/07 02:37:41 INFO: 
Level 0 [ ]: NumTables: 03. Size: 876 B of 0 B. Score: 0.00->0.00 StaleData: 0 B Target FileSize: 64 MiB
Level 1 [ ]: NumTables: 00. Size: 0 B of 10 MiB. Score: 0.00->0.00 StaleData: 0 B Target FileSize: 2.0 MiB
Level 2 [ ]: NumTables: 00. Size: 0 B of 10 MiB. Score: 0.00->0.00 StaleData: 0 B Target FileSize: 2.0 MiB
Level 3 [ ]: NumTables: 00. Size: 0 B of 10 MiB. Score: 0.00->0.00 StaleData: 0 B Target FileSize: 2.0 MiB
Level 4 [ ]: NumTables: 00. Size: 0 B of 10 MiB. Score: 0.00->0.00 StaleData: 0 B Target FileSize: 2.0 MiB
Level 5 [ ]: NumTables: 00. Size: 0 B of 10 MiB. Score: 0.00->0.00 StaleData: 0 B Target FileSize: 2.0 MiB
Level 6 [B]: NumTables: 00. Size: 0 B of 10 MiB. Score: 0.00->0.00 StaleData: 0 B Target FileSize: 2.0 MiB
Level Done
badger 2021/07/07 02:37:41 INFO: All 3 tables opened in 0s
badger 2021/07/07 02:37:41 INFO: Discard stats nextEmptySlot: 0
badger 2021/07/07 02:37:41 INFO: Set nextTxnTs to 3
badger 2021/07/07 02:37:41 INFO: Deleting empty file: /tmp/QiiTrans/000005.vlog
badger 2021/07/07 02:37:41 INFO: Lifetime L0 stalled for: 0s
badger 2021/07/07 02:37:41 INFO: 
Level 0 [ ]: NumTables: 03. Size: 876 B of 0 B. Score: 0.00->0.00 StaleData: 0 B Target FileSize: 64 MiB
Level 1 [ ]: NumTables: 00. Size: 0 B of 10 MiB. Score: 0.00->0.00 StaleData: 0 B Target FileSize: 2.0 MiB
Level 2 [ ]: NumTables: 00. Size: 0 B of 10 MiB. Score: 0.00->0.00 StaleData: 0 B Target FileSize: 2.0 MiB
Level 3 [ ]: NumTables: 00. Size: 0 B of 10 MiB. Score: 0.00->0.00 StaleData: 0 B Target FileSize: 2.0 MiB
Level 4 [ ]: NumTables: 00. Size: 0 B of 10 MiB. Score: 0.00->0.00 StaleData: 0 B Target FileSize: 2.0 MiB
Level 5 [ ]: NumTables: 00. Size: 0 B of 10 MiB. Score: 0.00->0.00 StaleData: 0 B Target FileSize: 2.0 MiB
Level 6 [B]: NumTables: 00. Size: 0 B of 10 MiB. Score: 0.00->0.00 StaleData: 0 B Target FileSize: 2.0 MiB
Level Done
[LOG]: EN -> JA: 新規取得: 
badger 2021/07/07 02:37:41 INFO: All 3 tables opened in 1ms
badger 2021/07/07 02:37:41 INFO: Discard stats nextEmptySlot: 0
badger 2021/07/07 02:37:41 INFO: Set nextTxnTs to 3
badger 2021/07/07 02:37:41 INFO: Deleting empty file: /tmp/QiiTrans/000006.vlog
badger 2021/07/07 02:37:41 INFO: Lifetime L0 stalled for: 0s
badger 2021/07/07 02:37:41 INFO: 
Level 0 [ ]: NumTables: 04. Size: 1.1 KiB of 0 B. Score: 0.00->0.00 StaleData: 0 B Target FileSize: 64 MiB
Level 1 [ ]: NumTables: 00. Size: 0 B of 10 MiB. Score: 0.00->0.00 StaleData: 0 B Target FileSize: 2.0 MiB
Level 2 [ ]: NumTables: 00. Size: 0 B of 10 MiB. Score: 0.00->0.00 StaleData: 0 B Target FileSize: 2.0 MiB
Level 3 [ ]: NumTables: 00. Size: 0 B of 10 MiB. Score: 0.00->0.00 StaleData: 0 B Target FileSize: 2.0 MiB
Level 4 [ ]: NumTables: 00. Size: 0 B of 10 MiB. Score: 0.00->0.00 StaleData: 0 B Target FileSize: 2.0 MiB
Level 5 [ ]: NumTables: 00. Size: 0 B of 10 MiB. Score: 0.00->0.00 StaleData: 0 B Target FileSize: 2.0 MiB
Level 6 [B]: NumTables: 00. Size: 0 B of 10 MiB. Score: 0.00->0.00 StaleData: 0 B Target FileSize: 2.0 MiB
Level Done
@KEINOS KEINOS added the bug Something isn't working label Jul 7, 2021
KEINOS added a commit that referenced this issue Jul 7, 2021
@KEINOS
feat: issue #8 再現テスト
6bb7f29
KEINOS added a commit that referenced this issue Jul 7, 2021
@KEINOS
fix: issue #8 空の場合は DB も API も叩かない
f2288ed
mergify bot pushed a commit that referenced this issue Jul 7, 2021
@KEINOS
Fix issue #8 (#9)
3338a44 
* feat: issue #8 再現テスト

* fix: issue #8 空の場合は DB も API も叩かない

* docs: fix godot

* docs: ドキュメントのアップデート
@KEINOS KEINOS mentioned this issue Jul 8, 2021
Merged
@KEINOS
Copy link
Owner Author

KEINOS commented Jul 8, 2021

Fixed in PR #9

@KEINOS KEINOS closed this as completed Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KEINOS