feat: config ctype #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weichweich
suggested changes
Nov 23, 2023
backend/src/config.ts
Outdated
Comment on lines
29
to
34
| export const CTYPE_HASH = | ||
| loadEnv('CTYPE_HASH') || | ||
| '0x3291bb126e33b4862d421bfaa1d2f272e6cdfc4f96658988fbcffea8914bd9ac' | ||
| export const TRUSTED_ATTESTERS = | ||
| loadEnv('TRUSTED_ATTESTERS') || | ||
| 'did:kilt:4pehddkhEanexVTTzWAtrrfo2R7xPnePpuiJLC7shQU894aY' |
There was a problem hiding this comment.
Would be nice to move the hash and did to constants and describe what they are. (which attester, which ctype)
There was a problem hiding this comment.
If there is really no definition for the constants on .env, the loadEnv() is going to throw before the fallback option is processed.
Comment on lines
5
to
7
| // Here you can set which type of credential (cType) your dApp will request users to login. | ||
| // You can change it by importing a different one from the list. | ||
| // The default is the Email CType by SocialKYC and SocialKYC as the Issuer |
weichweich
reviewed
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/KILTprotocol/ticket/issues/2911
Creating a configurable ctype with trusted attesters and attributes.
How to test:
Please provide a brief step-by-step instruction.
If necessary provide information about dependencies (specific configuration, branches, database dumps, etc.)
Checklist: