-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pymod manylinux wheels built on travis #213
Merged
klayoutmatthias
merged 25 commits into
KLayout:master
from
lightwave-lab:pymod-manylinux
Dec 30, 2018
Merged
Pymod manylinux wheels built on travis #213
klayoutmatthias
merged 25 commits into
KLayout:master
from
lightwave-lab:pymod-manylinux
Dec 30, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added +x permission to fix_wheel
Here are the wheels for this build: https://pypi.org/project/klayout/0.26.0.dev10/#files |
Hi Thomas, thanks for the thoughtful comments. I'm still not friend with setuptools, but I hope I'll improve :-) Best regards, Matthias |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Matthias,
Warning: Only merge this after #212 .
I apologize in advance for the long pull request. Even though the commits are long, the functionality changes are simple:
pip install klayout
in linux distros download pre-built images from PyPI.org. I had to fix a bug in the auditwheel project in the meantime.auditwheel repair
could not figure out the library dependencies in klayout. I submitted a PR Test cases: Unwanted RPATH overwrite and Failing to patch internal non-py extensions pypa/auditwheel#134 Hopefully they will take it.ccache
in the build steps to reuse most of the built objects between travis runs if the source code hasn't changed.pya/__init__.py
to better reflect how it behaves inside Klayout's app.ci-scripts/docker/development_notes/README.md
Here's an example of what the travis builds look like now: https://travis-ci.org/lightwave-lab/klayout/builds/470707822
Best,
Thomas