Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pymod manylinux wheels built on travis #213

Merged
merged 25 commits into from
Dec 30, 2018

Conversation

thomaslima
Copy link
Collaborator

@thomaslima thomaslima commented Dec 20, 2018

Hi Matthias,

Warning: Only merge this after #212 .

I apologize in advance for the long pull request. Even though the commits are long, the functionality changes are simple:

  • I am generating pip wheels for linux using the manylinux1 policy. This makes pip install klayout in linux distros download pre-built images from PyPI.org. I had to fix a bug in the auditwheel project in the meantime. auditwheel repair could not figure out the library dependencies in klayout. I submitted a PR Test cases: Unwanted RPATH overwrite and Failing to patch internal non-py extensions pypa/auditwheel#134 Hopefully they will take it.
  • I enabled ccache in the build steps to reuse most of the built objects between travis runs if the source code hasn't changed.
  • I changed pya/__init__.py to better reflect how it behaves inside Klayout's app.
  • I uploaded two versions to pypi.org in the process: klayout-0.26.0-dev9 and klayout-0.26.0-dev10.
  • While I was doing all this, I documented my thought process in ci-scripts/docker/development_notes/README.md

Here's an example of what the travis builds look like now: https://travis-ci.org/lightwave-lab/klayout/builds/470707822

Best,
Thomas

@thomaslima thomaslima mentioned this pull request Dec 20, 2018
1 task
@thomaslima
Copy link
Collaborator Author

Here are the wheels for this build: https://pypi.org/project/klayout/0.26.0.dev10/#files
Install with pip install klayout==0.26.0.dev10

@thomaslima thomaslima changed the title WIP: Pymod manylinux Pymod manylinux Dec 27, 2018
@thomaslima thomaslima changed the title Pymod manylinux Pymod manylinux wheels built on travis Dec 27, 2018
@thomaslima thomaslima added the bug label Dec 27, 2018
@thomaslima thomaslima added enhancement travis travis-related issues and removed bug labels Dec 27, 2018
@klayoutmatthias
Copy link
Collaborator

Hi Thomas,

thanks for the thoughtful comments. I'm still not friend with setuptools, but I hope I'll improve :-)

Best regards,

Matthias

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement travis travis-related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants