Skip to content
This repository has been archived by the owner on Nov 8, 2020. It is now read-only.

Commit

Permalink
Updated SharpZipLib to a hand-built bugfixed copy.
Browse files Browse the repository at this point in the history
Uses the patch from icsharpcode/SharpZipLib#53 .
Thank you, @Novn, for writing this.

Uses the build fixes from https://github.com/Arakis/SharpZipLib for
Mono. Thank you, @arakis, for providing these.

The branch I built from is at
https://github.com/pjf/SharpZipLib/tree/ckan_gh221

Attentioning @bastianeicher who is maintaining a totally awesome
SharpZipLib patches branch. @Novn's patch above fixes the bug
described at http://community.sharpdevelop.net/forums/t/21758.aspx .
There's a test file at
https://github.com/pjf/CKAN/blob/221_ziplib/t/data/gh221.zip which shows
the presence of the bug when combined with the test at
https://github.com/pjf/CKAN/blob/221_ziplib/CKAN/Tests/ZipLib.cs .

Closes #221.
Closes KSP-CKAN/CKAN-meta#33

@malahx: I'll be releasing an updated CKAN client shortly with these
fixes.
  • Loading branch information
pjf committed Oct 31, 2014
1 parent bb2ad89 commit 5c66073
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion CKAN.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
<HintPath>..\packages\Newtonsoft.Json.6.0.5\lib\net40\Newtonsoft.Json.dll</HintPath>
</Reference>
<Reference Include="ICSharpCode.SharpZipLib">
<HintPath>..\packages\SharpZipLib.0.86.0\lib\20\ICSharpCode.SharpZipLib.dll</HintPath>
<HintPath>..\packages\SharpZipLib.0.86.0-pjf-ckan_gh221\ICSharpCode.SharpZipLib.dll</HintPath>
</Reference>
<Reference Include="log4net">
<HintPath>..\packages\log4net.2.0.3\lib\net40-full\log4net.dll</HintPath>
Expand Down

0 comments on commit 5c66073

Please sign in to comment.