Merge #3347 Skip modules with parse errors in deserialization

CHANGELOG.md

@@ -19,6 +19,7 @@ All notable changes to this project will be documented in this file.
 - [Core] Tell SharpZipLib to use Unicode when opening zips (#3345 by: DasSkelett; reviewed: HebaruSan)
 - [GUI] Make incompatible mods warning dialog use newlines instead of commas (#3346 by: DeltaDizzy; reviewed: DasSkelett)
 - [Core] Fix crash when overwriting manually installed files (#3349 by: HebaruSan; reviewed: DasSkelett)
+- [Core] Skip modules with parse errors in deserialization (#3347 by: HebaruSan; reviewed: DasSkelett)
 
 ### Internal
 

Core/Registry/AvailableModule.cs

@@ -9,6 +9,7 @@
 using CKAN.Versioning;
 using log4net;
 using Newtonsoft.Json;
+using Newtonsoft.Json.Serialization;
 
 namespace CKAN
 {
@@ -51,6 +52,14 @@ public AvailableModule(string identifier)
         internal SortedDictionary<ModuleVersion, CkanModule> module_version =
             new SortedDictionary<ModuleVersion, CkanModule>();
 
+        [OnError]
+        private void OnError(StreamingContext context, ErrorContext errorContext)
+        {
+            log.WarnFormat("Discarding CkanModule, failed to parse {0}: {1}",
+                errorContext.Path, errorContext.Error.GetBaseException().Message);
+            errorContext.Handled = true;
+        }
+
         /// <summary>
         /// Record the given module version as being available.
         /// </summary>