Skip to content

Commit

Permalink
Merge #1401: Show mod name and not internal ID
Browse files Browse the repository at this point in the history
* Postremus/install_names:
  Show name and version of the mod we are (un)installing previously we only showed the identifier, which can be different from the actual mod name
  • Loading branch information
pjf committed Sep 1, 2015
2 parents e6c26db + 9771c18 commit 9ef4024
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ All notable changes to this project will be documented in this file.

### Features

- [All] When installing and uninstalling mods, the mod name and version will be used rather than the internal identifier. (Postremus, #1401)
- [GUI] The GUI changeset screen now provides explanations as to why changes are being made. (Postremus, #1412)

### Internal
Expand Down
7 changes: 4 additions & 3 deletions Core/ModuleInstaller.cs
Original file line number Diff line number Diff line change
Expand Up @@ -187,12 +187,12 @@ public void InstallList(
{
if (!ksp.Cache.IsCachedZip(module.download))
{
User.RaiseMessage(" * {0}", module);
User.RaiseMessage(" * {0} {1}", module.name, module.version);
downloads.Add(module);
}
else
{
User.RaiseMessage(" * {0} (cached)", module);
User.RaiseMessage(" * {0} {1}(cached)", module.name, module.version);
}
}

Expand Down Expand Up @@ -701,7 +701,8 @@ public void UninstallList(IEnumerable<string> mods)

foreach (string mod in goners)
{
User.RaiseMessage(" * {0}", mod);
InstalledModule module = registry_manager.registry.InstalledModule(mod);
User.RaiseMessage(" * {0} {1}", module.Module.name, module.Module.version);
}

bool ok = User.RaiseYesNoDialog("\nContinue?");
Expand Down

0 comments on commit 9ef4024

Please sign in to comment.