Merge #3651 Highlight incompatible mods recursively

KSP-CKAN · Aug 31, 2022 · a1ffa56 · a1ffa56
2 parents 79445be + 8887476
commit a1ffa56
Show file tree

Hide file tree

Showing 4 changed files with 31 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -17,6 +17,7 @@ All notable changes to this project will be documented in this file.
 - [GUI] Show reverse relationships (#3638, #3649 by: HebaruSan; reviewed: techman83)
 - [GUI] Debounce search events on all platforms (#3641 by: HebaruSan; reviewed: techman83)
 - [Multiple] Improvements for failed repo updates (#3645 by: HebaruSan; reviewed: techman83)
+- [GUI] Highlight incompatible mods recursively (#3651 by: HebaruSan; reviewed: techman83)
 
 ## Bugfixes
 

diff --git a/Core/Registry/IRegistryQuerier.cs b/Core/Registry/IRegistryQuerier.cs
@@ -125,6 +125,14 @@ IEnumerable<string> FindReverseDependencies(
         /// <param name="with_provides">If set to false will not check for provided versions.</param>
         /// <returns>The version of the mod or null if not found</returns>
         ModuleVersion InstalledVersion(string identifier, bool with_provides = true);
+
+        /// <summary>
+        /// Check whether any versions of this mod are installable (including dependencies) on the given game versions
+        /// </summary>
+        /// <param name="identifier">Identifier of mod</param>
+        /// <param name="crit">Game versions</param>
+        /// <returns>true if any version is recursively compatible, false otherwise</returns>
+        bool IdentifierCompatible(string identifier, GameVersionCriteria crit);
     }
 
     /// <summary>

diff --git a/Core/Registry/Registry.cs b/Core/Registry/Registry.cs
@@ -537,6 +537,20 @@ public IEnumerable<CkanModule> IncompatibleModules(GameVersionCriteria ksp_versi
             return sorter.Incompatible.Values.Select(avail => avail.Latest(null)).ToList();
         }
 
+        /// <summary>
+        /// Check whether any versions of this mod are installable (including dependencies) on the given game versions.
+        /// Quicker than checking CompatibleModules for one identifier.
+        /// </summary>
+        /// <param name="identifier">Identifier of mod</param>
+        /// <param name="crit">Game versions</param>
+        /// <returns>true if any version is recursively compatible, false otherwise</returns>
+        public bool IdentifierCompatible(string identifier, GameVersionCriteria crit)
+        {
+            // Set up our compatibility partition
+            SetCompatibleVersion(crit);
+            return sorter.Compatible.ContainsKey(identifier);
+        }
+
         /// <summary>
         /// <see cref="IRegistryQuerier.LatestAvailable" />
         /// </summary>

diff --git a/GUI/Controls/ModInfo.cs b/GUI/Controls/ModInfo.cs
@@ -585,7 +585,7 @@ private TreeNode findDependencyShallow(IRegistryQuerier registry, RelationshipDe
                 out CkanModule matched))
             {
                 return matched != null
-                    ? indexedNode(registry, matched, relationship, true)
+                    ? indexedNode(registry, matched, relationship, crit)
                     : nonModuleNode(relDescr, null, relationship);
             }
 
@@ -603,13 +603,13 @@ private TreeNode findDependencyShallow(IRegistryQuerier registry, RelationshipDe
                 && relDescr.ContainsAny(new string[] { dependencyModules[0].identifier }))
             {
                 // Only one exact match module, return a simple node
-                return indexedNode(registry, dependencyModules[0], relationship, crit != null);
+                return indexedNode(registry, dependencyModules[0], relationship, crit);
             }
             else
             {
                 // Several found or not same id, return a "provides" node
                 return providesNode(relDescr.ToString(), relationship,
-                    dependencyModules.Select(dep => indexedNode(registry, dep, relationship, crit != null))
+                    dependencyModules.Select(dep => indexedNode(registry, dep, relationship, crit))
                 );
             }
         }
@@ -623,11 +623,11 @@ private IEnumerable<TreeNode> ReverseRelationships(IRegistryQuerier registry, Tr
                 compat.SelectMany(otherMod =>
                     GetModRelationships(otherMod, relationship)
                         .Where(r => r.MatchesAny(toFind, null, null))
-                        .Select(r => indexedNode(registry, otherMod, relationship, true)))
+                        .Select(r => indexedNode(registry, otherMod, relationship, crit)))
                 .Concat(incompat.SelectMany(otherMod =>
                     GetModRelationships(otherMod, relationship)
                         .Where(r => r.MatchesAny(toFind, null, null))
-                        .Select(r => indexedNode(registry, otherMod, relationship, false)))));
+                        .Select(r => indexedNode(registry, otherMod, relationship, crit)))));
         }
 
         private TreeNode providesNode(string identifier, RelationshipType relationship, IEnumerable<TreeNode> children)
@@ -641,9 +641,11 @@ private TreeNode providesNode(string identifier, RelationshipType relationship,
             };
         }
 
-        private TreeNode indexedNode(IRegistryQuerier registry, CkanModule module, RelationshipType relationship, bool compatible)
+        private TreeNode indexedNode(IRegistryQuerier registry, CkanModule module, RelationshipType relationship, GameVersionCriteria crit)
         {
             int icon = (int)relationship + 1;
+            bool compatible = crit == null ? false
+                : registry.IdentifierCompatible(module.identifier, crit);
             string suffix = compatible ? ""
                 : $" ({registry.CompatibleGameVersions(manager.CurrentInstance.game, module.identifier)})";
             return new TreeNode($"{module.name} {module.version}{suffix}", icon, icon)