Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to download any package due to a SSL/TLS issue #2142

Closed
dymanoid opened this issue Oct 15, 2017 · 15 comments
Closed

Unable to download any package due to a SSL/TLS issue #2142

dymanoid opened this issue Oct 15, 2017 · 15 comments
Labels
Enhancement New features or functionality Network Issues affecting internet connections of CKAN

Comments

@dymanoid
Copy link

dymanoid commented Oct 15, 2017

Just updated CKAN to the latest version, then tried to update all the installed mods.
As usual, selected "add available updates" --> "apply".
But the downloading fails. I get 3 error messages in the popups, then the update process stops. The messages all look like:

Failed to download "package URL here" - error: The underlying connection was closed: Could not establish trust relationship for the SSL/TLS secure channel.

With the previous CKAN version, I've never had any troubles updating the packages (nor any network connection issues).

Do you need any additional info?

CKAN Version:
v1.22.5

Operating System:
Win10 Home RU

The issue you are experiencing:
Unable to download packages.

How to recreate this issue:

  • start CKAN (automatic repository refresh is enabled)
  • click "add available updates"
  • click "apply changes"
  • click "apply"

CKAN error codes (if applicable):
no error codes, error messages see above

@Horcrux
Copy link

Horcrux commented Oct 15, 2017

Looks like Spacedock's SSL cert expired, so this is kind of on them.

@Horcrux
Copy link

Horcrux commented Oct 15, 2017

I have created a commit that hacks around this here, based on the advice in this thread. Note this completely disables SSL checks of any kind, so use with extreme caution.

@Olympic1
Copy link
Member

The SSL cert should now be fixed, can you confirm

@Horcrux
Copy link

Horcrux commented Oct 15, 2017

@Olympic1 looks good! This probably closes the issue.

@fat-lobyte
Copy link

fat-lobyte commented Jan 13, 2018

The SSL cert should now be fixed, can you confirm

Hi, it seems that the spacedock certificates are expired again, and I can't download anything from there using CKAN :(
Could we maybe have a workaround to allow accepting expired certificates, considering this is a recurring issue?

@Demcrew
Copy link

Demcrew commented Jan 14, 2018

Confirmed, Spacedock seems to have their cert. expired again.
Thought these kind of things are renewed on a yearly basis ?

@lljakll
Copy link

lljakll commented Jan 14, 2018

they useletsencrypt which is a free SSL/TTL certificate authority with a quarterly renewal. It's great if you setup the auto renew. https://community.letsencrypt.org/t/how-to-automatically-renew-certificates/4393

@viperfan7
Copy link

As a work around for this, can we get an option to ignore SSL cert errors in CKAN?

@coolkirk1701
Copy link

Just to confirm, I am having the same issue. for me, its on editor extensions redux and janitor's closet if that helps.

mister-walter added a commit to mister-walter/CKAN that referenced this issue Jan 14, 2018
Following Horcrux's previous workaround described in KSP-CKAN#2142, disable SSL certificate verification when downloading mods.

PLEASE USE THIS WITH EXTREME CAUTION - SSL CHECKS PROTECT YOUR COMPUTER
@mister-walter
Copy link

mister-walter commented Jan 14, 2018

I've resurrected Horcrux's fix on the disable-ssl-check branch on my fork. Note that you'll have to compile it yourself to use the version with the "fix".

As Horcrux said previously: "Note this completely disables SSL checks of any kind, so use with extreme caution."

I'm willing to work on a better fix for this if there's interest, I'm not sure what you folks feel is an appropriate solution (checkbox in options menu/command line flag? automatically disable SSL and retry spacedock downloads if they fail?)

@HebaruSan HebaruSan added Enhancement New features or functionality Network Issues affecting internet connections of CKAN labels Jan 14, 2018
@HebaruSan
Copy link
Member

I've been trying to determine exactly what the vulnerability level is here so we can make an informed decision, but most of the commentary for site owners revolves around avoiding annoying errors on your page and alert fatigue, neither of which have to do with enumerating viable attack vectors. Let's see if this makes sense...

KerbalStuff is currently replaced by a malicious web site, such that it can't even be mentioned on the KSP forums (it's auto-corrected to "*"). If we completely ignore expired certificates, then such a site could likewise replace SpaceDock someday and use its old expired certificates to provide CKAN users with malware downloads.

Is that true? But we would de-list SpaceDock URLs in NetKAN and CKAN-meta if that happened. And with #2243 validating the hashes of downloads before installing them in the next update, we have a form of end-to-end security that would mean the downloads would have to be the same as what we indexed, so we should be safe unless we index malicious downloads.

... I'm not confident enough in any of that to make code changes. Can anyone share a fuller picture of the security implications of expired certificates?

@7ranceaddic7
Copy link

This has been fixed. The site certificate has been updated.

@Demcrew
Copy link

Demcrew commented Jan 14, 2018

Confirmed this works now.

Given the above comments, an option in CKAN to disable the cert check would be helpfull.
And indeed a warning dialog box with links to the official information about the risks, so everyone is also educated :)

@PGTBoos
Copy link

PGTBoos commented Mar 12, 2018

Ckan still fails, no way to update?

@linuxgurugamer
Copy link
Contributor

download and install 1.4 manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New features or functionality Network Issues affecting internet connections of CKAN
Projects
None yet
Development

No branches or pull requests