-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] ConsoleUI should refresh mod list after changing compatible versions #3352
Comments
Looks like we need an CKAN/ConsoleUI/ModListScreen.cs Lines 477 to 488 in 6b2340c
|
I guess we can even clone |
I think we aren't refreshing after changing the metadata repos either, so we should compare that as well if we want to do it on-demand. |
That one needs an |
To no one's surprise, |
Background
Have you made any manual changes to your GameData folder (i.e., not via CKAN)?
Yeah the person who encountered it did, but that's irrelevant.
Problem
Describe the bug
I've just spent some time helping a macOS+ConsoleUI user on the r/KerbalSpaceProgram Discord who wasn't able to find ClickThroughBlocker in the mod list, even after adding KSP 1.11 (and a whole bunch more) to the list of compatible versions.
Turns out, the mod list doesn't reload after you change compatible versions, thus changing compatible KSP versions "doesn't have an effect", only after pressing F5 or restarting KSP.
I was able to reproduce this.
Steps to reproduce
Expected behavior
It should show up directly when coming back to the mod list of the instance, i.e. the mod list should refresh automatically after changing compatible KSP versions (or active metadata repositories).
That's what a user would expect to happen, and that's what happens in the GUI as well.
At the very least we should show some sort of notice that refreshing the mod list manually is required to take the changes into effect.
The text was updated successfully, but these errors were encountered: