Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where do we store the CKAN repo? #38

Closed
pjf opened this issue Oct 5, 2014 · 2 comments
Closed

Where do we store the CKAN repo? #38

pjf opened this issue Oct 5, 2014 · 2 comments

Comments

@pjf
Copy link
Member

pjf commented Oct 5, 2014

Right now we've got sample files in the meta directory of this repo, but going forward that's probably not ideal. These files are likely to be updated often, either by mod authors or automated tools, and by having them here we clutter the commit log of changes to the code and design with changes to the data that we use.

I'm going to suggest we create a github organisation (KSP-CKAN, since CKAN is already taken), migrate this repo to there, and have another repo which is just for the meta files. This means:

  • The CKAN client can dowload a single zip to get all the metainfo it needs. This is is fast, and easy, especially because we already have code that downloads and processes zipfiles.
  • We can more easily implement code reviews before merge, especially of my own code, by sending pull requests to the repo. (HT to @eggrobin for the suggestion.)
  • Teams are better than people. I actually want to be playing KSP, and having a org makes it easier for me to hand everything to another person when I get to do so. :)
@pjf pjf added this to the Usable Release milestone Oct 5, 2014
@pjf
Copy link
Member Author

pjf commented Oct 5, 2014

@Wizarth @rafl @johndalton @techman83: Just a heads-up that I've moved the CKAN to an org. You may need to tweak the upstreams in your git configs for checked out files. Otherwise everything should work much the same. :)

@pjf
Copy link
Member Author

pjf commented Oct 6, 2014

I've now created https://github.com/KSP-CKAN/CKAN-meta , and have moved all the .ckan files across to it. There's a pending pull request that will have travis validate them all every update, which will be awesome.

While we may end up having the CKAN repo somewhere else in the future, this is an easy spot for it to exist for now, especially since we can download the whole thing as a single zip.

Marking this closed, unless there's any objections to the current approach.

@pjf pjf closed this as completed Oct 6, 2014
RichardLake pushed a commit to RichardLake/CKAN that referenced this issue May 30, 2015
RichardLake pushed a commit to RichardLake/CKAN that referenced this issue May 30, 2015
Log the encountered AVC string before blowing up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant