[Bug]: Exception clicking on "Update" checkbox in UI

[gczobel]

Is there an existing issue for this?

• I have searched the existing issues

Operating System

Windows 11

CKAN Version

1.34.0

Games

KSP 1

Game Version

1.12.5.3190

Did you make any manual changes to your game folder (i.e., not via CKAN)?

Yes. Updated CleverSatCore.cfg from Github directly as no release was created.

Describe the bug

Not used CKAN for a week. After update to 1.34.0 an update for Contract Configurator shows.
Clicking on the update checkbox raised an exception with the text: "Already contains module: ContractConfigurator."

Looks a UI bug. I used ckan consoleui to update the mod without any issue.

Steps to reproduce

Start Ckan and Refresh
Click update checkbox
Exception

Relevant log output

************** Exception Text **************
System.ArgumentException: Already contains module: ContractConfigurator
   at CKAN.RelationshipResolver.Add(CkanModule module, SelectionReason reason)
   at CKAN.RelationshipResolver.AddModulesToInstall(CkanModule[] modules)
   at CKAN.IRegistryQuerierHelpers.FindRemovableAutoInstalled(IRegistryQuerier querier, List`1 installedModules, HashSet`1 dlls, IDictionary`2 dlc, GameVersionCriteria crit)
   at CKAN.IRegistryQuerierHelpers.FindRemovableAutoInstalled(IRegistryQuerier querier, List`1 installedModules, GameVersionCriteria crit)
   at CKAN.GUI.ModList.ComputeFullChangeSetFromUserChangeSet(IRegistryQuerier registry, HashSet`1 changeSet, GameVersionCriteria version)
   at CKAN.GUI.ManageMods.UpdateChangeSetAndConflicts(GameInstance inst, IRegistryQuerier registry)
   at CKAN.GUI.GUIMod.set_SelectedMod(CkanModule value)
   at CKAN.GUI.GUIMod.SetUpgradeChecked(DataGridViewRow row, DataGridViewColumn col, Nullable`1 set_value_to)
   at CKAN.GUI.ManageMods.ModGrid_CellValueChanged(Object sender, DataGridViewCellEventArgs e)
   at System.Windows.Forms.DataGridView.OnCellValueChanged(DataGridViewCellEventArgs e)
   at System.Windows.Forms.DataGridViewCell.SetValue(Int32 rowIndex, Object value)
   at System.Windows.Forms.DataGridView.PushFormattedValue(DataGridViewCell& dataGridViewCurrentCell, Object formattedValue, Exception& exception)
   at System.Windows.Forms.DataGridView.CommitEdit(DataGridViewCell& dataGridViewCurrentCell, DataGridViewDataErrorContexts context, DataGridViewValidateCellInternal validateCell, Boolean fireCellLeave, Boolean fireCellEnter, Boolean fireRowLeave, Boolean fireRowEnter, Boolean fireLeave)
   at System.Windows.Forms.DataGridView.CommitEdit(DataGridViewDataErrorContexts context)
   at CKAN.GUI.ManageMods.ModGrid_CurrentCellDirtyStateChanged(Object sender, EventArgs e)
   at System.Windows.Forms.DataGridView.OnCurrentCellDirtyStateChanged(EventArgs e)
   at System.Windows.Forms.DataGridView.set_IsCurrentCellDirtyInternal(Boolean value)
   at System.Windows.Forms.DataGridView.NotifyCurrentCellDirty(Boolean dirty)
   at System.Windows.Forms.DataGridViewCheckBoxCell.OnCommonContentClick(DataGridViewCellEventArgs e)
   at System.Windows.Forms.DataGridView.OnCellContentClick(DataGridViewCellEventArgs e)
   at System.Windows.Forms.DataGridView.OnCommonCellContentClick(Int32 columnIndex, Int32 rowIndex, Boolean doubleClick)
   at System.Windows.Forms.DataGridViewCell.OnMouseUpInternal(DataGridViewCellMouseEventArgs e)
   at System.Windows.Forms.DataGridView.OnCellMouseUp(DataGridViewCellMouseEventArgs e)
   at System.Windows.Forms.DataGridView.OnMouseUp(MouseEventArgs e)
   at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

[HebaruSan]

Thanks for the report. This was fixed in #3944 and is planned to be included in a hotfix release today or tomorrow. 🤞