[Bug]: Unhandled Exception "Already contains module" when update detected

[MatthewMWR]

Is there an existing issue for this?

• I have searched the existing issues

Operating System

Windows 11 23H2

CKAN Version

1.34.0

Games

KSP 1

Game Version

1.12.5

Did you make any manual changes to your game folder (i.e., not via CKAN)?

No

Describe the bug

I recently accepted the update from CKAN 1.33.x to 1.34.0. On the next run of CKAN an update to 'KSP Community Fixes' was detected. When I click the Update All button or the individual update checkbox, I get a popup window for an unhandled exception with the following details. Exception details are in the Log section of the bug template.

Steps to reproduce

Open CKAN
Click Update All
(it happens every time, but the first time I may have selected the individual update checkbox first, then decided to click Update All button, not sure if this matters)

Relevant log output

************** Exception Text **************
System.ArgumentException: Already contains module: KSPCommunityFixes
   at CKAN.RelationshipResolver.Add(CkanModule module, SelectionReason reason)
   at CKAN.RelationshipResolver.AddModulesToInstall(CkanModule[] modules)
   at CKAN.IRegistryQuerierHelpers.FindRemovableAutoInstalled(IRegistryQuerier querier, List`1 installedModules, HashSet`1 dlls, IDictionary`2 dlc, GameVersionCriteria crit)
   at CKAN.IRegistryQuerierHelpers.FindRemovableAutoInstalled(IRegistryQuerier querier, List`1 installedModules, GameVersionCriteria crit)
   at CKAN.GUI.ModList.ComputeFullChangeSetFromUserChangeSet(IRegistryQuerier registry, HashSet`1 changeSet, GameVersionCriteria version)
   at CKAN.GUI.ManageMods.UpdateChangeSetAndConflicts(GameInstance inst, IRegistryQuerier registry)
   at CKAN.GUI.GUIMod.set_SelectedMod(CkanModule value)
   at CKAN.GUI.GUIMod.SetUpgradeChecked(DataGridViewRow row, DataGridViewColumn col, Nullable`1 set_value_to)
   at CKAN.GUI.ManageMods.ModGrid_CellValueChanged(Object sender, DataGridViewCellEventArgs e)
   at System.Windows.Forms.DataGridView.OnCellValueChanged(DataGridViewCellEventArgs e)
   at System.Windows.Forms.DataGridViewCell.SetValue(Int32 rowIndex, Object value)
   at CKAN.GUI.GUIMod.SetUpgradeChecked(DataGridViewRow row, DataGridViewColumn col, Nullable`1 set_value_to)
   at CKAN.GUI.ManageMods.MarkAllUpdates()
   at System.Windows.Forms.ToolStripItem.RaiseEvent(Object key, EventArgs e)
   at System.Windows.Forms.ToolStripMenuItem.OnClick(EventArgs e)
   at System.Windows.Forms.ToolStripItem.HandleClick(EventArgs e)
   at System.Windows.Forms.ToolStripItem.HandleMouseUp(MouseEventArgs e)
   at System.Windows.Forms.ToolStrip.OnMouseUp(MouseEventArgs mea)
   at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at System.Windows.Forms.ToolStrip.WndProc(Message& m)
   at System.Windows.Forms.MenuStrip.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

[HebaruSan]

Thanks for the report. This was fixed in #3944 and is planned to be included in a hotfix release today or tomorrow. 🤞

[HebaruSan]

Duplicate of #3952