Fixed TargetInvocationException when deselecting a mod some other mod… #1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… depends on Fixes #1371
Postremus
changed the title
|
I actually have no idea why the test failed. Can anyone help? |
|
The test case is actually wrong. It tries to get the conflicts from the Gui's mainmodlist, but it never adds the mods to it. |
|
@Postremus : Hooray! Bugs in the test suite are better than bugs in our code! :) |
ayan4m1
changed the title
|
The initial failure was because MainModList.Modules was empty due to improper test case setup. I am still encountering issues after that that need more attention, but I will try to fix this up and open a PR to your PR branch when I get the test fixed. |
|
@ayan4m1 please just take over this pr, not that much time for ckan atm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… depends on
Fixes #1371