Improve Steam install detection #1444
Conversation
…nfig file to get the path.
|
Oh cool! I always knew that in theory we could go parsing Steam's config files, but I didn't realise it could be this straightforward. :) |
|
I am a bit curious (don't take this as criticism i am a new software engineer and just don't understand) but why do pull requests take so long to merge? You seem to have a Continuous Integration system setup, and from my understanding merging often means dev's branches are less likely to conflict with each other, reducing the admin work. If it's to do with stability, shouldn't there be a "Dev" branch that is continuous integration, with the "Dev" branch being merged to a release branch when it is deemed stable enough? Thanks, |
This is an excellent question. And the answer is nothing to do with stability, and all to do with human psychology! While everyone who has a collaboration bit has the ability to merge PRs, I think there's been a bit of a hesitancy to do so. I'm sure there are many reasons for this: merging a PR can make you feel responsible if you've missed any bugs in it, you may find reviewing code less fun than writing code, and the good old fashioned bystander effect where it's easy to believe that someone else will do it. In our case, I suspect it's mostly bystander effect. I have scheduled sprints where I work on the CKAN, so it's easy to feel that for any given PR, I'll review and merge it if nobody else does. And that belief is indeed correct, except that we've built up a backlog of PRs as a result, especially in the last couple of months where I've been on the conference circuit and pouring hours into The Kerbal Book so we can hit our Christmas deadline. I'd actually love for us to move towards something similar to what Rust do, where a bot assigns PRs to humans as soon as they come in. |
* master: (22 commits) Changed the AssignentSpacer of the FileIniDataParser instance to the empty string. This removes spaces around the '=' in the kde mimeapps and .desktop files and should enable KDE to parse the files without issues. Should fix #1498 Fix typo bool->boolean Documet find_matches_files option Rebuild Ships Directory on Load Add extra property to have find match on files for backward compatability Actually default use_filename_version to false Remove TODO Automatically populate ci resource Fix spelling Update Changelog Support asset matching Make filename as version opt-in Allow find to match on files as well as directories Remove old Jenkins API More robust Jenkins support CONTRIBUTING: Grammar fix back to pattern Pattern -> enum Bring the schema up to date Changelog joy for Steam location fixes (#1444, #1481) ...
If the steam game isn't found in the default spot. Parse the steam config file to get the path.