Fixed OS X cmdline not finding a valid KSP install #1480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested, works. merging with my thanks! |
Postremus
added a commit
that referenced
this pull request
Sep 25, 2015
Fixed OS X cmdline not finding a valid KSP install
|
Oh goodness, this bug would have been around for a very long time! Thank you so much for catching it! |
pjf
added a commit
that referenced
this pull request
Sep 27, 2015
pjf
added a commit
that referenced
this pull request
Sep 27, 2015
* origin/master: (33 commits) CHANGELOG: Document recent PRs: #1480, #1460, adjust #1476 Fixed OS X cmdline not finding a valid KSP install add missing % Add relevant changelog entry. Add identifier to metadata panel *chucklesnort* adding for posterity Consistency in capitalization between tabs Change the displayed text of WaitTabPage Release v1.14.2 aka Makemake CHANGELOG: #1454 - You can now cache while you cache. KSP class is more disposable, and we dispose it more from tests. NetFileCache now caches the cache directory so you can cache while you cache. NetFileCache: Updated docs to be more recent and relevant NetFileCache.IsMaybeCachedZip() - A faster way to maybe find your files CHANGELOG: AutoUpdater is faster and more resilient Tests for AutoUpdater/FetchLatestReleaseInfo Improved AutoUpdater release notes handling + tests Moar documentation for the autoupdater class. AutoUpdate: We no longer blame the user for our own code's failings. :) Documented auto-update internal methods. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this fixes issue #1109 or at least it did on my install of OS X...
Looking at the code I changed, I have a sneaking suspicion this issue may have been more than OS X and impacted every OS, but I have no means of testing that theory currently.
I am not a C# programmer so my bad if I have made some sort of C# faux-pas.