Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed schema to enforce structure of install direcitves #1578

Merged
merged 1 commit into from
Apr 10, 2016

Conversation

Zane6888
Copy link
Contributor

Found a JSON Schema friendly way of specifying that excactly one of 'file', 'find' and 'find_regexp' must be present.

@Olympic1 Olympic1 added the Schema Issues affecting the schema label Feb 28, 2016
@pjf
Copy link
Member

pjf commented Mar 13, 2016

Thank you so much, @Zane6888 ! It looks like we're behind on PRs; so thanks for your patience with the delay. I'm testing this now. :)

@Dazpoet
Copy link
Member

Dazpoet commented Apr 10, 2016

Looking over this I feel safe merging it, however I don't know if this will undo the changes made since the creation of this PR in #1597 or if it will just work by some github magic?

@politas
Copy link
Member

politas commented Apr 10, 2016

Wouldn't it say there was a merge conflict in that case?

@Dazpoet
Copy link
Member

Dazpoet commented Apr 10, 2016

I shall apply the magic of TIAS with the knowledge that it can easily be reverted in the case of breakage.

@Dazpoet Dazpoet merged commit 43c2ce0 into KSP-CKAN:master Apr 10, 2016
@Dazpoet
Copy link
Member

Dazpoet commented Apr 10, 2016

It worked :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Schema Issues affecting the schema
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants