Add Asterisk to legend in CLI list command #1664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An * for status shows up whenever a mod falls through all the status tests without matching anything, thus implying an inability for CKAN to intelligently handle the mod. Since "Unknown" has been used to refer to mods that have been installed through CKAN but are now unable to be found in the registry, I have selected "Broken" as a term to describe the status of these mods.
|
Ref #1660, for which this is only a partial fix. |
|
Deleted the wrong branch |
|
So it's failing on Mono 3.2.8? I didn't think we supported that version of Mono. |
|
All you did was modify a string and add a comment, the failure was unrelated to your changes. No issues after rebuild. |
|
I figured as much. |
|
This looks very sensible to me. Merging now. :) As an aside, CKAN shows me '*' on the cmdline for some mods which can be upgraded via the GUI. |
pjf
added a commit
that referenced
this pull request
Jun 19, 2016
* politas/AddAsteriskToLegend: Add Asterisk to legend in CLI list command An * for status shows up whenever a mod falls through all the status tests without matching anything, thus implying an inability for CKAN to intelligently handle the mod. Since "Unknown" has been used to refer to mods that have been installed through CKAN but are now unable to be found in the registry, I have selected "Broken" as a term to describe the status of these mods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An * for status shows up whenever a mod falls through all the status tests without matching anything, thus implying an inability for CKAN to intelligently handle the mod. Since "Unknown" has been used to refer to mods that have been installed through CKAN but are now unable to be found in the registry, I have selected "Broken" as a term to describe the status of these mods.