Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Mono 3.2.8 from Mono testing #1715

Merged
merged 1 commit into from
May 17, 2016
Merged

Conversation

dbent
Copy link
Member

@dbent dbent commented May 6, 2016

@pjf @techman83
#1645 is failing in Travis on the Mono 3.2.8 version because of errors like these:

System.TypeInitializationException : An exception was thrown by the type initializer for CKAN.Versioning.KspVersionRange
  ----> System.TypeInitializationException : An exception was thrown by the type initializer for CKAN.Versioning.KspVersionBound
  ----> System.NullReferenceException : Object reference not set to an instance of an object

There is no reason why a NullReferenceException should occur in the type initializer for KspVersionBound, this suggests a bug in the Mono 3.2.8 runtime:

  • The error does not occur on Mono 3.10.0, Mono 4.2.3, or the .NET runtime.
  • A similar error was fixed in Mono in the 3.2.x era.

Do we even support running CKAN on such an old version of Mono?

@politas
Copy link
Member

politas commented May 7, 2016

No. Mono 4.0 / .Net 4.5 is the minimum now.

@techman83
Copy link
Member

I think the intention was for the core to be compliant as far back as practical. We are leaning on the newer APIs in the core already from what I recall. It's a small change to turn it back on if required.

@techman83 techman83 merged commit 44dd821 into master May 17, 2016
@Olympic1 Olympic1 deleted the feature/remove_mono_3.2.8 branch May 23, 2016 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants