Fix variable names and doc wording #1849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -265,7 +265,7 @@ public override string Message | |||
| // our base class? | |||
|
|
|||
| public ModNotInstalledKraken(string mod, string reason = null, Exception inner_exception = null) | |||
| :base(reason, inner_exception) | |||
| : base(reason, inner_exception) | |||
There was a problem hiding this comment.
Shouldn't this be innerException, too?
|
I don't think the forum thread link in the Contribution guidelines page has been updated to the new thread. |
|
Rebased and updated |
| @@ -481,7 +476,7 @@ private void InitializeComponent() | |||
| this.ModList.ColumnHeadersHeightSizeMode = System.Windows.Forms.DataGridViewColumnHeadersHeightSizeMode.AutoSize; | |||
| this.ModList.Columns.AddRange(new System.Windows.Forms.DataGridViewColumn[] { | |||
| this.Installed, | |||
| this.UpdateCol, | |||
| this.Update, | |||
There was a problem hiding this comment.
Please revert, or expand name to UpdateColumn or UpdateSelection or some such. "Update" gives us build warnings.
Main.Designer.cs(1614,44): warning CS0108: `CKAN.Main.Update' hides inherited member `System.Windows.Forms.Control.Update()'. Use the new keyword if hiding was intended
/usr/lib/mono/4.5-api/System.Windows.Forms.dll (Location of the symbol related to previous warning)
Main.Designer.cs(1600,44): warning CS0169: The private field `CKAN.Main.UpdateCol' is never used
|
Whew! That's a lot to review! |
|
Yep, and thanks for doing so! I made the changes related to points you brought up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not exhaustive, but a step in the direction of conforming all source to use the conventions that were suggested by Microsoft.