Add regexp second test for vref filespecs #1919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayan4m1
reviewed
Oct 21, 2016
| remoteIndex = i; | ||
| break; | ||
| } | ||
| else if (Regex.IsMatch(files[i].Name, internalFilePath)) |
There was a problem hiding this comment.
Consider instead if (internalFilePath.Equals(files[i]?.Name) || Regex.IsMatch(files[i]?.Name, internalFilePath))
There was a problem hiding this comment.
I thought about combining the tests, and it probably makes sense to do it that way. We're not cycling through the list a second time for the other test.
Hang on, what's the "?" you've got there?
There was a problem hiding this comment.
the "?" declares a nullable type, and means that the type before it may have a null value.
ayan4m1
added
Enhancement
|
The schema is for .ckan files, not .netkan files, so this doesn't affect it. |
politas
changed the title
politas
added a commit
that referenced
this pull request
Oct 26, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1918
Shouldn't impact any existing $vref filespecs, as they all have complete paths.