Add filters, deprecate bundles and install options. #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They don't do anything yet. For KSP-CKAN#129.
As part of KSP-CKAN#129. Obviously these cause travis to fail without their corresponding code.
Updates the spec, the schema, and the code. Includes tests. Closes KSP-CKAN#113 (deprecate things). Closes KSP-CKAN#129 (add filter keywords). This will require an update to CKAN-meta, which I've already got ready.
I only half removed it before, and caused travis to cry.
Our parser was apparently ignoring these, but we should be strict in our validation.
Also more errors discovered and corrected.
|
I'm a terrible person; this PR now does more than it says on the tin, as it also corrects a number of minor JSON errors in the NetKAN directory, and also adds code to allow travis to validate these automatically in the future. |
|
Uh oh, I might have found a bug here. Hold for now. |
AlexanderDzhoganov
added a commit
that referenced
this pull request
Oct 31, 2014
Add filters, deprecate bundles and install options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the spec, the schema, and the code. Includes tests.
Closes #113 (deprecate things). Closes #129 (add filter keywords).
This will require an update to CKAN-meta, which I've already got ready.