Always switch to progress tab when starting a [re/un]install #2351
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If you:
... then the progress tab does not display. Instead only the status bar reports progress. Additional odd behaviors and glitches may be observed after this as well.
If you install a mod normally first (before step 3), then it works as expected.
Cause
The sequence of calls needed to use the install flow correctly was:
CKAN/GUI/Main.cs
Lines 971 to 977 in 624839f
Previously, the
ShowWaitDialog
call was missing fromreinstallToolStripMenuItem_Click
. This call creates or activates the progress tab, depending on whether it already exists, and also does some initialization of the progress bar.Changes
Now the
ShowWaitDialog
call is moved toInstallMods
, which is the function thatRunWorkerAsync
calls to do its work. This simplifies the code for installing/uninstalling/reinstalling and fixes the reinstall flow.Fixes #2343.