Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests #2410

Merged
merged 2 commits into from
Apr 17, 2018
Merged

Add more tests #2410

merged 2 commits into from
Apr 17, 2018

Conversation

HebaruSan
Copy link
Member

@HebaruSan HebaruSan commented Apr 15, 2018

Tests are added (catching regressions unless otherwise noted):

The tests' names are of the form MethodBeingTested_Scenario_DesiredOutcome.
The code follows the Arrange / Act / Assert structure.

The tests for CKAN.CkanModule are moved from Module to CkanModuleTests so programmers familiar with CkanModule will have an easier time finding them.

Also courtesy of @DasSkelett (HebaruSan#4), references are added to Tests.csproj to allow running the tests directly in Visual Studio.

@HebaruSan HebaruSan added Pull request Netkan Issues affecting the netkan data Tests Issues affecting the internal tests Relationships Issues affecting depends, recommends, etc. labels Apr 15, 2018
@politas
Copy link
Member

politas commented Apr 15, 2018

Oooh! I like tests!

@DasSkelett
Copy link
Member

Hey, may I open a pull request to your branch to add NUnit 3 Test Adapter to Tests/packages.config?
It's necessary to run NUnit tests inside VisualStudio.

@HebaruSan
Copy link
Member Author

@DasSkelett, sure, bring it on!

@politas politas merged commit 12bcdf0 into KSP-CKAN:master Apr 17, 2018
politas added a commit that referenced this pull request Apr 17, 2018
@HebaruSan HebaruSan deleted the feature/more-tests branch April 17, 2018 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Netkan Issues affecting the netkan data Relationships Issues affecting depends, recommends, etc. Tests Issues affecting the internal tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants