Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If you run the master HEAD version in Windows, you get this exception at startup:
Cause
This line initializes the purge button dropdown menu from #2536 in the settings window:
CKAN/GUI/SettingsDialog.Designer.cs
Line 44 in 681dd7e
However,
this.components
isn't currently being set. In the main form from which the above line was borrowed, there's a line to set it, but this isn't present in the settings form:CKAN/GUI/Main.Designer.cs
Line 31 in 681dd7e
We should have copied and pasted this when we made the dropdown, but it's not apparent that it's required or might be missing.
Changes
Now
this.components
is initialized in the settings window and the exception is gone.The cache settings text boxes are also made 5 pixels taller, since they were a bit squished on Windows previously.