Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tray icon menu position and color on Linux (Gnome) #2587

Merged
merged 1 commit into from
Nov 29, 2018

Conversation

HebaruSan
Copy link
Member

Problem

#2565 added a tray icon with a context menu. On Linux, it has light text on a white background and it can be displayed mostly off-screen:

screenshot

(The icon is invisible as well. I don't know why that is, so this pull request doesn't attempt to fix it.)

Cause

Mono?

Changes

Now the background matches other menus, and the position is always on screen:

image

In addition, the tray icon related code is moved from Main.cs to MainTrayIcon.cs.

@HebaruSan HebaruSan added Bug Something is not working as intended GUI Issues affecting the interactive GUI Pull request Linux Issues specific for Linux Mono Issues specific for Mono labels Nov 24, 2018
@HebaruSan HebaruSan changed the title Fix tray icon menu position and color Fix tray icon menu position and color on Linux Nov 24, 2018
@politas
Copy link
Member

politas commented Nov 29, 2018

Which tray does it go in?

@HebaruSan
Copy link
Member Author

Depends on your desktop, I don't know that much about MATE. Maybe in one of the task bars, near the clock?

@politas
Copy link
Member

politas commented Nov 29, 2018

I've got an Indicator Applet and an IBus applet, that show different "tray" stuff.

@HebaruSan
Copy link
Member Author

I guess I'd expect it in the indicator applet? Mine for GNOME Shell is in the TopIcons Plus extension. But if you see a suspicious blank space anywhere, try right clicking it.

@politas
Copy link
Member

politas commented Nov 29, 2018

Nope, doesn't show up anywhere, and then refuses to unminimise
Correction: My "Notification Area" applet expands a little, but the space shows an echo of the neighbouring icon and doesn't respond to any mouse clicks.

@politas politas changed the title Fix tray icon menu position and color on Linux Fix tray icon menu position and color on Linux (Gnome) Nov 29, 2018
@politas
Copy link
Member

politas commented Nov 29, 2018

I'll just have to take your word that it works on Gnome.

@politas politas merged commit 99e7f13 into KSP-CKAN:master Nov 29, 2018
@politas
Copy link
Member

politas commented Nov 29, 2018

I may well be the only Mate user of CKAN, and I don't care about this feature, as it doesn't have the main element I wanted for a tray applet (handling multiple KSP installs).

@HebaruSan HebaruSan deleted the fix/mono-tray-icon-menu branch November 29, 2018 04:21
HebaruSan added a commit to HebaruSan/CKAN that referenced this pull request Dec 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working as intended GUI Issues affecting the interactive GUI Linux Issues specific for Linux Mono Issues specific for Mono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants