Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notify when falling back to archive.org URL #2892

Merged
merged 1 commit into from
Oct 19, 2019
Merged

Notify when falling back to archive.org URL #2892

merged 1 commit into from
Oct 19, 2019

Conversation

HebaruSan
Copy link
Member

Problem

If a mod fails to download but it has a redistributable license, we silently fall back to its archive.org URL. Going by the messages printed, it looks like we're still downloading the original URL. While our file hashes ensure that only the proper ZIP will be installed, it would be nice to inform users when this happens.

Changes

Now we print a message when we start a fallback URL.

$ _build/ckan.exe install opentree --allow-incompatible
About to install...

 * OpenTree 2.5 (spacedock.info, 62.3 KiB)
 * Module Manager 4.0.3 (cached)

Continue? [Y/n] 

Downloading "https://spacedock.info/mod/1623/OpenTree/download/2.5"
Failed to download "https://spacedock.info/mod/1623/OpenTree/download/2.5", trying fallback "https://archive.org/download/OpenTree-2.5/8BD18970-OpenTree-2.5.zip"
0 B/sec - downloading - 0 B left - 100%               
Installing mod "OpenTree 2.5"
Installing mod "ModuleManager 4.0.3"
Updating registry
Committing filesystem changes
Rescanning GameData
Done!

Fixes #2891.

@HebaruSan HebaruSan added Easy This is easy to fix Core (ckan.dll) Issues affecting the core part of CKAN Pull request Network Issues affecting internet connections of CKAN labels Oct 19, 2019
@HebaruSan HebaruSan requested a review from DasSkelett October 19, 2019 01:06
DasSkelett
DasSkelett approved these changes Oct 19, 2019
View reviewed changes
Copy link
Member

@DasSkelett DasSkelett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

DasSkelett added a commit that referenced this pull request Oct 19, 2019
@DasSkelett
Merge #2892 Notify when falling back to archive.org URL
fbcb3a9
@DasSkelett DasSkelett merged commit b5e40d9 into KSP-CKAN:master Oct 19, 2019
@HebaruSan HebaruSan deleted the fix/fallback-message branch October 19, 2019 18:17
@HebaruSan HebaruSan mentioned this pull request Feb 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DasSkelett DasSkelett DasSkelett approved these changes

Assignees
No one assigned
Labels
Core (ckan.dll) Issues affecting the core part of CKAN Easy This is easy to fix Network Issues affecting internet connections of CKAN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] No indication if using Archive.org fallback
2 participants
@HebaruSan @DasSkelett