Fix ArgumentException in ConsoleUI recommendations #2990
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If you have a lot of modules installed, ConsoeUI's "audit recommendations" option can throw an exception:
Reported in #2986 (comment) .
Cause
ModuleInstaller.FindRecommendations
can return a module in the suggested-by list that's also in the recommendations or sugggestions.ConsoleUI.DependencyScreen
puts all three lists into one dictionary keyed by theCkanModule
, which causes exceptions to be thrown on duplicates.Changes
Now
ModuleInstaller.FindRecommendations
excludes recommended and suggested modules from the supported-by list. No module will appear in more than one of the lists.