Don't report an unknown error if it is known #2995
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When there's an exception thrown during the installation of mods, we catch the usual ones and log an explanation message on the WaitTabPage.
However in
PostInstallMods()
which is called when the background worker completesInstallMods()
, the messageAn unknown error occurred, please try again!
is written to the "log".This message is actually not true most of the time, because e.g. download errors or inconsistency problems are all catched and a nice explaining error message has already been printed out.
Changes
Now
PostInstallMods()
distinguishes catched and uncatched errors (the second one will result inRunWorkerCompletedEventArgs.Error
being set).It keeps the old message for uncatched errors, but displays a new one for known ones:
(Suggestions to change this message are welcome)
This way we don't contradict ourselves, and also encourage the users to report metadata/client problems.