-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prompt user to overwrite manually installed files #3043
Conversation
I don't have the time to familiarise myself to review, but this is really really cool! Excellent work @HebaruSan ! |
Encountered this through accident: But I know that removing the original files, if they are not conflicting, is basically impossible currently, since we don't know them, we only know the DLL. Got an idea? Somewhat related: Assuming a correct manual installation, there might still be additional files in the subfolders that won't be overwritten by the CKAN-installed version (for example if the AD mod is an older version, or if there are dynamically generated cache/save/config files). This would make the process much more complicated than it currently is, and it's going into rabbit holes we wanted to avoid, so I am fine with letting it as is. |
f3e2e56
to
94c26d9
Compare
94c26d9
to
0359937
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, works very well now. Nice work!
Motivation
Most new KSP users start out by installing mods manually and find out about CKAN later, at which point they already have an install with some mods and would like to have CKAN take over.
Currently this user's only option is to manually clean out their game folders and start from scratch with CKAN. Some of the manually installed mods will show up in the GUI as "AD", but CKAN can't remove/install/upgrade them. Other manually installed mods will simply show up as not installed, but error out if you try to install them.
Changes
Now you can:
(Or instead of steps 1-3, select a manually installed mod that doesn't show up as AD and add it to be installed normally)
The apply button becomes enabled
Files that are different are highlighted at the top of the list.
Click Yes to replace the files
Similarly, CmdLine's
install
command can overwrite AD mods' files with the same prompt.The Versions tab is involved because I don't know how to turn the current "AD" text in the checkbox column into an installable checkbox in a clean and clear way. This is kind of a pilot program for some delicate functionality so I'd like to take a cautious approach. If this goes well we can try to build upon it and make the UI better.
Fixes #949.
Fixes #2186.
Fixes #3029.