-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run workflows in Mono Docker containers #3091
Run workflows in Mono Docker containers #3091
Conversation
This comment has been minimized.
This comment has been minimized.
Well, that was fast 😮 Added the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏃
eb0cdc5
to
90b0480
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚴
Almost...
|
Hmm, I could either specify the mono version directly in the |
This is really neat! That makes the builds way faster and less prone to issues with installing all the mono packages across so many versions. |
Motivation
The CI builds still take quite a long time to finish, since installing Mono takes around 10 minutes.
@techman83 had the excellent idea of running the builds in Docker containers from the images published here.
Downloading the images should be way faster than installing and pre-compiling it.
Changes
There exists a
container
keyword for workflow jobs: https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idcontainerIf I understood the documentation correctly, it makes all steps of this job run in the specified container after pulling it from the Docker hub.
Let's see if it works.
Also realized that I messed up the Discord notifications in #3089 since the env var is named differently.