Don't prompt to delete SCANsat's settings at upgrade #3103
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
GameData/SCANsat/PluginData/Settings.cfg
Cause
SCANsat creates PluginData as an empty folder and only uses it for saving its Settings.cfg, so it naturally meets the criteria for a removable config-only dir at uninstall. When we upgrade, we:
Changes
Now when we install a directory, we remove it from the list of empty directories to ask the user about. This removes the prompt from the upgrade flow but still presents it at uninstall.