-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup project, update builds, fixes #3108
Conversation
Huh, this builds fine in a
No idea why the automated builds say they're missing reference assemblies. |
Something in this created a bunch of
This broke the compile when I switched to another branch. Should get those back into |
Those are the NuGet PackageReferences, I was looking into getting that into the build folder but that isn't possible atm |
020eec3
to
b8e997b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The copyright symbol thing isn't a big deal, but we can't make netkan error out without a file parameter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Can you squash these commits before merge? Rebase commits à la "Merge branch 'master' into ..." are always a bit confusing in the commit history. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's hope Mono gets its stuff together and restores cross-platform compatibility soon. Would be nice to update the rest too.
Anyways, thanks a lot for that!
Problem
I wanted to prepare CKAN for .NET 5.0, and some other stuff I'm working on, but I coudn't open the project in VS.
Cause
Not sure what exactly, but I traced it back to CKAN.Core. Something was probably malformed in the
.csproj
file. I let VS recreate the file and now I can open it again.Changes
.csproj
fileszh-CN.resx
file (400 kB saved)NOTES:
obj
folders outside_build
but currently you can't change their output path.