Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache build tools #3127

Merged
merged 4 commits into from
Jul 27, 2020
Merged

Cache build tools #3127

merged 4 commits into from
Jul 27, 2020

Conversation

HebaruSan
Copy link
Member

@HebaruSan HebaruSan commented Jul 27, 2020 •
edited
Loading

  • Now all build actions cache _build/tools
    • NuGet
    • NUnit
    • ILRepack
  • Now all build actions cache _build/cake
    • Cake.SemVer
    • semver
    • Cake.Docker
  • Now the release build step caches _build/tools, _build/cake, _build/lib/nuget, and ~/.nuget/packages
  • Indenting in the yml files is more consistent

This should allow quicker builds with fewer downloads.

@HebaruSan HebaruSan added Pull request Build Issues affecting the build system labels Jul 27, 2020
@HebaruSan HebaruSan requested a review from DasSkelett July 27, 2020 17:38
@HebaruSan

This comment has been minimized.

Sign in to view
DasSkelett
DasSkelett approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@DasSkelett DasSkelett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Shortens the build times by another 10-20 seconds 🎉

@HebaruSan HebaruSan merged commit 65cef77 into master Jul 27, 2020
@HebaruSan HebaruSan deleted the feature/cache-build-tools branch July 27, 2020 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DasSkelett DasSkelett DasSkelett approved these changes

Assignees
No one assigned
Labels
Build Issues affecting the build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HebaruSan @DasSkelett