Better message when ZipFile throws NotSupportedException #3128
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See #3066 and #3123; if Mono users in a non-en_US locale don't install
mono-complete
, this exception can be thrown:Cause
SharpZipLib apparently uses some kind of locale-specific code in its ZIP validation logic, which does not like being called without the locale data installed.
Changes
Now we catch that exception on Mono and tell the user to install
mono-complete
. The mod installation will still fail, because we need to confirm the file is valid, and we can't do that if this is thrown.