Don't fail modpack export when having unindexed mods installed #3139
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When you have mods or mod versions installed that are not in the list of available modules ("DarkKAN modules"), the modpack export tab freezes.
This is caused by
registry.LatestAvailable()
inAddGroup()
throwing anModuleNotFoundKraken
for unknown mods when trying to fetch the abstract for each installed mod.Changes
InstalledModule
with the given identifier, and use its abstract property. We should always have anInstalledModule
for each module we're handling in the export logic, and if for some reason we haven't, it shouldn't break anything.And from DasSkelett#9 thanks to @HebaruSan:
RegistryManager.GenerateModpack
, so now as far as Core is concerned, modpacks should consist only of indexed modsFixes #3138
...maybe, hard to say without the registry or any information about installed mods, but it solved it for me.