Remove invalid zip files in NetKAN #3156
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Invalid zip files that fail the
ZipValid
check fill up the bot's disk over time. The tempfiles but never get removed or moved into the cache, thus filling the disk with every indexer run.In contrast, files failing to download at all get removed immediately, and files failing inflation later on are still stay in the cache and don't get redownloaded for the next try.
Changes
Simply remove the file if it fails the
ZipValid
check.This has a downside when using netkan manually, if one would want to investigate the zip file after netkan fails (I remember my comment...). Now you have to download the file manually again to check it out.
I tried to think of an easy solution, like keeping the file if
--debug
is set, but as of right now we don't save that anywhere globally accessible in netkan.I think it's worth it though, and not every mod is as big as HumanStuff, so redownloading the file manually isn't much of a deal usually.