Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete netkan tmp files if cache fills up #3169

Merged
merged 1 commit into from
Oct 13, 2020
Merged

Delete netkan tmp files if cache fills up #3169

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions Netkan/Services/CachingHttpService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,12 +99,22 @@ private string DownloadPackage(Uri url, string identifier, DateTime? updated, Ur
break;
}

return _cache.Store(
primaryUrl,
downloadedFile,
string.Format("netkan-{0}.{1}", identifier, extension),
move: true
);
try
{
return _cache.Store(
primaryUrl,
downloadedFile,
$"netkan-{identifier}.{extension}",
move: true
);
}
catch (IOException exc)
{
// If cache is full, don't also fill /tmp
log.Debug($"Failed to store to cache: {exc.Message}");
File.Delete(downloadedFile);
throw;
}
}
}

Expand Down