-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confirmation prompt for Cmdline upgrades #3204
Merged
HebaruSan
merged 1 commit into
KSP-CKAN:master
from
HebaruSan:fix/cmdline-confirm-upgrade
Nov 22, 2020
Merged
Confirmation prompt for Cmdline upgrades #3204
HebaruSan
merged 1 commit into
KSP-CKAN:master
from
HebaruSan:fix/cmdline-confirm-upgrade
Nov 22, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
Bug
Something is not working as intended
Enhancement
New features or functionality
Cmdline
Issues affecting the command line
Core (ckan.dll)
Issues affecting the core part of CKAN
Pull request
labels
Nov 20, 2020
HebaruSan
force-pushed
the
fix/cmdline-confirm-upgrade
branch
from
November 20, 2020 23:01
16358a3
to
ad666f0
Compare
DasSkelett
reviewed
Nov 21, 2020
I noticed two whitespace inconsistencies:
We also do funny things for
|
HebaruSan
force-pushed
the
fix/cmdline-confirm-upgrade
branch
from
November 22, 2020 00:42
ad666f0
to
c757850
Compare
HebaruSan
force-pushed
the
fix/cmdline-confirm-upgrade
branch
from
November 22, 2020 00:45
c757850
to
dc1907f
Compare
Try now? |
Looks good! Thanks!! |
DasSkelett
approved these changes
Nov 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Bug
Something is not working as intended
Cmdline
Issues affecting the command line
Core (ckan.dll)
Issues affecting the core part of CKAN
Enhancement
New features or functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems
CmdLine's
upgrade
command is pretty inconsistent withinstall
andremove
:Removing "CKAN.InstalledModule"
for each installed module being upgradedOther problems:
ckan upgrade --all
ModuleInstaller.InstallList
prints "Rescanning GameData" even if it's not doing thatMotivation
As of #3190,
ckan upgrade --all
now upgrades AD mods to CKAN-managed. While this is probably what users want on balance, it won't be expected at first, so we should tell them that it's about to happen and allow them to cancel.Cause
Upgrade
based on strings, notCkanModule
sInstalledModule
objectChanges
ckan upgrade
prints the changes to be made and asks the user whether to continueckan upgrade
no longer prints double messages at start and endckan upgrade --all
passes the installed modules to be removed to theRelationshipResolver
, as per Fix dependency resolution in mod upgrades #3200CancelledActionKraken
if the user opts to abort (remove
previously just printed and returned)