Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow label to pin installed mod version #3220

Merged
merged 1 commit into from
Jan 18, 2021

Conversation

HebaruSan
Copy link
Member

Motivation

Sometimes a user doesn't want to upgrade an upgradeable mod for the foreseeable future:

image

image

image

Changes

Now a new "Don't upgrade" checkbox is added to the Edit Labels form:

image

If checked, mods with this label will not be upgraded by the "Add available updates" button (though the Update column will still appear to let users know an update exists and isn't being installed, and the user can still choose to upgrade manually):

image

A user installing CKAN for the first time will have a default label "Held" created with this feature enabled; existing users will have to create their own labels.

@HebaruSan HebaruSan added Enhancement New features or functionality GUI Issues affecting the interactive GUI Pull request labels Dec 2, 2020
@HebaruSan HebaruSan requested a review from DasSkelett December 2, 2020 15:49
@HebaruSan
Copy link
Member Author

Pushed some small layout fixes for the form, basically the controls are moved/expanded down to fill the blank space at the bottom. Let me know if you care about updating the screenshots, otherwise I'll leave them as-is out of laziness.

@DasSkelett
Copy link
Member

Ugh, for some reason I can't enter Umlauts in any textbox on Mono. Works fine on Windows of course.
(Want to translate "Held" with "Zurückgehalten")

Let's do some debugging...

@HebaruSan
Copy link
Member Author

This worked for me (set a compose key, then type compose+shift+' followed by u):

@DasSkelett
Copy link
Member

DasSkelett commented Jan 18, 2021

Does work in other applications, but unfortunately not in CKAN (nor the notepad sample from Mono).
Going to switch from Mono stable to nightly again and see if it makes a difference.

I can still translate it with an umlaut, and I think it would get displayed correctly, but it would be nice if users could create labels with the same names as the default labels to re-create them.

Copy link
Member

@DasSkelett DasSkelett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to ignore my umlaut problem for the time being, it isn't related to this PR anyways, and maybe it's just something broken on my system.

The changes of this PR work fine. Maybe we can also find a solution for our ConsoleUI users someday.

@HebaruSan
Copy link
Member Author

Oops, just meant to re-base but forgot to pull first, need to re-add the German...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New features or functionality GUI Issues affecting the interactive GUI i18n Issues regarding the internationalization of CKAN and PRs that need translating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants