Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual cues for incompatibility reasons #3271

Merged
merged 1 commit into from
Jan 30, 2021

Conversation

HebaruSan
Copy link
Member

@HebaruSan HebaruSan commented Jan 18, 2021

Motivation

We continue to get questions about why a mod is shown as incompatible when the user expects it to be compatible. The answer is that there is a conflict or an unsatisfied dependency, but this is generally not obvious.

Changes

Now if a mod is incompatible because of the KSP versions, <!> is added to its Versions tab, which shows the range of compatible versions:

image

And if a mod is incompatible because of a conflict or an unsatisfied dependency, <!> is added to its Relationships tab, which shows those relationships:

image

Ideally these would have been big red stop sign icons instead, but Mono's TabControl does not display icons (it makes room for them if you set TabPage.ImageIndex or TabPage.ImageKey, but they're never drawn 🙄).

Priorities in choosing these characters:

  • They should be wide enough to get attention but not too wide (I found parentheses and square brackets too narrow)
  • They should imply an alert or attention condition (hence exclamation mark)
  • They should have a slight visual resemblance to a stop sign (angle brackets almost form a hexagon, which is almost an octagon)
  • They should not crash Mono (as 🛑 does)

@HebaruSan HebaruSan added Enhancement New features or functionality Easy This is easy to fix GUI Issues affecting the interactive GUI Pull request labels Jan 18, 2021
@DasSkelett
Copy link
Member

What do you think about opening the relevant tab as well? Should increase the chance to draw the user's attention, might be a bit disruptive, though.

@HebaruSan
Copy link
Member Author

I thought of that but wasn't sure about it. I'm open to it if you think it's a good idea, though.

@DasSkelett
Copy link
Member

Hm, I am not fully confident either. In that case, let's leave it out for now, and try whether the angle brackets that almost form a hexagon, which is almost an octagon already suffice to help users find out what's up.

Copy link
Member

@DasSkelett DasSkelett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised!

@HebaruSan HebaruSan merged commit 4d02381 into KSP-CKAN:master Jan 30, 2021
@HebaruSan HebaruSan deleted the feature/tab-incompat-highlight branch January 30, 2021 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy This is easy to fix Enhancement New features or functionality GUI Issues affecting the interactive GUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants