Fix checkbox sorting #3297
Merged
Fix checkbox sorting #3297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
Bug
DasSkelett
reviewed
Feb 22, 2021
HebaruSan
force-pushed
the
fix/checkbox-sort
branch
from
b63bb04 to
2ec5366
Compare
DasSkelett
approved these changes
Feb 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If you have an AD mod and sort by the Installed column, the AD mod will be shown after all the non-installed compatible mods. This is bad because the installed mods should be listed together at the top.
Originally the sort order of a checkbox column was:
Cause
In #3205 the checkbox column sort logic was rewritten and the original logic was lost; it is now:
Changes
Now the sort order for a checkbox column is restored to what it was.