Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In #3223 we tried to separate KSP1-specific logic from generic core logic in preparation for KSP2, see #2863.
However, just having tried to make those changes doesn't exercise the code robustly the way that an actual additional game would. The more bugs we find before KSP2 comes out, the better.
Background
#3264 started adding Factorio support and in the process found bugs and things that were missed relating to multi-game support. Eventually those were split into a separate commit, and now that commit is in this pull request.
Changes
ModuleInstallDescriptor
still had KSP1-specific logic; both are now moved toIGame
(ReservedPaths
andCreateableDirs
)Core/Games/KerbalSpaceProgram
GameInstance.Scan
now silently aborts if the game's default mod folder doesn't exist