Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-game fixes #3308

Merged
merged 1 commit into from
Mar 5, 2021
Merged

Multi-game fixes #3308

merged 1 commit into from
Mar 5, 2021

Conversation

HebaruSan
Copy link
Member

Motivation

In #3223 we tried to separate KSP1-specific logic from generic core logic in preparation for KSP2, see #2863.

However, just having tried to make those changes doesn't exercise the code robustly the way that an actual additional game would. The more bugs we find before KSP2 comes out, the better.

Background

#3264 started adding Factorio support and in the process found bugs and things that were missed relating to multi-game support. Eventually those were split into a separate commit, and now that commit is in this pull request.

Changes

  • Two places in ModuleInstallDescriptor still had KSP1-specific logic; both are now moved to IGame (ReservedPaths and CreateableDirs)
  • Some more KSP1-specific code is moved to Core/Games/KerbalSpaceProgram
  • The convention for matching all patch levels of a minor version in Factorio seems to be to set the maximum to MAJOR.MINOR.MAXINT. This caused an overflow in CKAN, so now we round MAXINT to Undefined
  • GameInstance.Scan now silently aborts if the game's default mod folder doesn't exist

@HebaruSan HebaruSan added Bug Something is not working as intended Core (ckan.dll) Issues affecting the core part of CKAN Pull request labels Mar 5, 2021
@HebaruSan HebaruSan requested a review from DasSkelett March 5, 2021 21:45
Copy link
Member

@DasSkelett DasSkelett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the patience! Looks very good ✔️

@HebaruSan HebaruSan merged commit 19f8b44 into KSP-CKAN:master Mar 5, 2021
@HebaruSan HebaruSan deleted the fix/multi-game branch March 5, 2021 22:54
@HebaruSan HebaruSan mentioned this pull request Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working as intended Core (ckan.dll) Issues affecting the core part of CKAN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants