-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple search boxes with OR logic in GUI #3323
Conversation
I'm expecting questions about what ✓ , ✓✗ and ✗ mean. Can you make the options more descriptive, or (if possible) make a legend. |
This comment has been minimized.
This comment has been minimized.
Just thinking ahead.
I like this idea. |
This comment has been minimized.
This comment has been minimized.
Gonna hold off on merging so @DasSkelett can check out the i18n changes. |
I'm surprised that my font has problems displaying Unicode though, I can't remember any problems anywhere else. I'm going to play around a bit and see if/how I can fix it on my system.
I can see your point there. But I'm not really happy leaving our users on their own having to find out how the software works through experimentation. Maybe I can think of another way to make it clear how the searches interact with each other. |
512fa7b
to
1be95c5
Compare
And who knows about Windows. Force pushed some new icons and updated button backcolor behavior.
Is this better for you now? Now updating |
f4322ed
to
f69d117
Compare
OK, it's a bit more visually busy, but if it helps users to understand how it works, then that's fine: |
Working on some fixes, need some time navigating through all those |
Force-pushing a simple rebase without any code changes so I can do a PR to your branch which also includes some adjustments to the pt-BR localization. Edit: well this did include the commits with changes, let me retry... |
84f0d97
to
195f9bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, appears to be stable now in my testing. Let's hope people appreciate all the new search combination possibilities!
Motivations
Changes
Addresses post-close comments in #2736 about wanting to search both name and description with OR-logic.
Fixes #3071.
Fixes #3301.