Fix crash when overwriting manually installed files #3349
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If you try to overwrite a manually installed file with the current dev build, an unhandled exception is thrown:
Cause
icsharpcode/SharpZipLib#84 changed the zip lib to throw an exception if you ask it for the length of a file in a ZIP. Before that I think it would have returned the correct length, because
ModuleInstaller.StreamsEqual
correctly reported whether files were the same.We upgraded to that version of the lib in #3329, so users are not yet affected by this.
Changes
Now
ModuleInstaller.StreamsEqual
compares its input streams without checking their lengths.Fixes #3348.