Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Japanese Localization #3394

Merged
merged 6 commits into from
Jun 13, 2021
Merged

Japanese Localization #3394

merged 6 commits into from
Jun 13, 2021

Conversation

utah239
Copy link
Contributor

@utah239 utah239 commented Jun 13, 2021

It's substantially my first contribution on github.
I have made some commit about Japanese Localization.
Plz check if it is correct, especially code matter.

utah239 added 6 commits June 12, 2021 03:30
ja-JP localization
Add Japanese translation
Add more Japanese translation and modify some expressions.
Add some code that enable Japanese localization.
@HebaruSan
Copy link
Member

HebaruSan commented Jun 13, 2021

Yes, the code looks great to me! It compiles and I am able to switch into the ja-JP translation.
Have you had a chance to try it out yet? There is a test build here with your changes:

If you notice anything that does not look right, we can try to fix it, otherwise this looks ready to merge!

@HebaruSan
Copy link
Member

(Note to others testing in Mono, I got missing character glyphs unless I set the locale in the environment as well:

LANG=ja_JP.utf-8 _build/ckan.exe

I don't think this can be helped, Mono needs to know which fonts to load somehow.)

@utah239
Copy link
Contributor Author

utah239 commented Jun 13, 2021

Yes, the code looks great to me! It compiles and I am able to switch into the ja-JP translation.
Have you had a chance to try it out yet? There is a test build here with your changes:

If you notice anything that does not look right, we can try to fix it, otherwise this looks ready to merge!

Yes, I have already tried making this build and checked if the layout is correct so far.

@HebaruSan HebaruSan merged commit b879e78 into KSP-CKAN:master Jun 13, 2021
@utah239 utah239 deleted the ja-JP branch June 14, 2021 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants