Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small changes to column titles #3403

Closed
wants to merge 7 commits into from
Closed

small changes to column titles #3403

wants to merge 7 commits into from

Conversation

vinix38
Copy link
Contributor

@vinix38 vinix38 commented Jun 26, 2021

I noticed that the "install/uninstall all" checkbox was moved upward, so I changed the text to a better version.
image
(that checkbox)
I also saw that there was a tooltip for that checkbox, is it possible to translate it? Or is it part of Core?
Note: some commits are redundant, as I haven't figured out how to compare against a pull request (still learning (: )

@HebaruSan
Copy link
Member

Thanks! Added this to #3400 as well since it is branched off of that.

I also saw that there was a tooltip for that checkbox, is it possible to translate it? Or is it part of Core?

Yes, it's possible, but it lives in a different file because WinForms treats tooltips as an afterthought:

<data name="ManageModsInstallAllCheckboxTooltip" xml:space="preserve"><value>Uncheck to uninstall all mods, check to clear change set</value></data>

Note: some commits are redundant, as I haven't figured out how to compare against a pull request (still learning (: )

This wiki page has some suggestions for working with branches in git, in case you want to try it:

In this case the "proper" thing would probably be to make your pull request here, using "git rebase" to connect it to the branch for #3400:

That way I would see it in my fork of the repo and be able to diff it against the current status of #3400, and after merging it would appear in #3400. But that may be kind of difficult, and this way works as well.

@vinix38
Copy link
Contributor Author

vinix38 commented Jun 26, 2021

I had forgotten this file, I'm going to make a tour of the history of all localized files to make sure I didn't forget anything
EDIT: for the filters in the search bar, will spaces create troubles? ("is:cached" --> "est: en cache")

@HebaruSan
Copy link
Member

EDIT: for the filters in the search bar, will spaces create troubles? ("is:cached" --> "est: en cache")

Good question, yes, those should not contain spaces.

@HebaruSan
Copy link
Member

Thanks for the updates, they've been added to #3400 as well. Is there anything remaining that you're planning to work on?

@vinix38
Copy link
Contributor Author

vinix38 commented Jun 26, 2021

I believe the French translation is now up to date, thank you :)

@HebaruSan
Copy link
Member

Cool, this will ride along with #3400 then! Thanks again for the updates.

@HebaruSan HebaruSan closed this Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants